Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various MP4Decrypt fixes #420

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

truedread
Copy link

@truedread truedread commented Aug 13, 2019

Fixed MP4Decrypt so it can:

  • Decrypt PIFF media
  • Select track by KID instead of track ID
  • Show progress

Fixes #368

@MythodeaLoL
Copy link

@barbibulle can u update this? thank u man.

}
if (tenc != NULL) {
const AP4_DataBuffer* key = m_KeyMap->GetKeyByKid(tenc->GetDefaultKid());
if (key != NULL) m_KeyMap->SetKey(trak->GetId(), key->GetData(), 16);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Writing to the key map from AP4_CencDecryptingProcessor breaks the constness of that map. It doesn't seem right. Can you explain why you need to write a key here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mp4decrypt couldn't properly handle selecting the track based on key ID, it only seemed to work by track ID.

@FugerZuer
Copy link

Any update on progress bar?

@m0ck69
Copy link

m0ck69 commented Aug 2, 2021

Yes, please add this. It's been so long...

@FugerZuer
Copy link

This modified version has a progress bar: https://github.com/NanDesuKa-FR/mp4decrypt_mod_linux

@AtherosKiller
Copy link

Any update on progress bar?

@dausruddin
Copy link

@FugerZuer link is dead

@2084x
Copy link

2084x commented Aug 15, 2024

one day...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mp4decrypt --show-progress doesn't actually show progress, broken?
8 participants